-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ks #1525
base: master
Are you sure you want to change the base?
Move ks #1525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I'm not sure about depending on spfunc
; that appears not to have been touched in three years and has one open issue noting an inaccuracy.
Further note: could you split
(Optionally more segregation of tests.) Part of the rationale is to make it easier to use this for additional tests — I'd like to add some for weighted sampling (for which we have several variants, so better to use a separate file). |
I see the point, but before we just copy pasted their zeta implementation |
84ec3a9
to
3c89aae
Compare
CHANGELOG.md
entrySummary
Motivation
#1519